Skip to content

MQE-1520: Consolidate WAIT_TIMEOUT in .env and pageload_timeout #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 26, 2019
Merged

MQE-1520: Consolidate WAIT_TIMEOUT in .env and pageload_timeout #512

merged 6 commits into from
Nov 26, 2019

Conversation

KevinBKozan
Copy link
Contributor

Description

  • Added WAIT_TIMEOUT to default yml file + default definition as this makes it required to be defined
  • Removed some dead code since it's always defined now.

@KevinBKozan
MQE-1520: Consolidate WAIT_TIMEOUT in .env and pageload_timeout in co…
be71f94 
…nfig

- changed functional.suite.dist to use wait timeout
- added default setters in bootstrap files (will always be defined)
- removed default in actionObject
@KevinBKozan
Merge branch 'develop' into MQE-1520
0792413
@KevinBKozan
MQE-1520: Consolidate WAIT_TIMEOUT in .env and pageload_timeout
ab0d3c5 
- Fixed Verification Tests
@KevinBKozan KevinBKozan changed the title MQE-1520: Consolidate WAIT_TIMEOUT in .env and pageload_timeout in c MQE-1520: Consolidate WAIT_TIMEOUT in .env and pageload_timeout Nov 21, 2019
@coveralls
Copy link

Coverage Status

Coverage increased (+0.7%) to 53.612% when pulling ab0d3c5 on MQE-1520 into 26ef6b0 on develop.

@coveralls
Copy link

coveralls commented Nov 21, 2019 •
edited
Loading

Coverage Status

Coverage increased (+1.3%) to 53.111% when pulling 009e7b6 on MQE-1520 into e4499a3 on develop.

jilu1
jilu1 suggested changes Nov 21, 2019
View reviewed changes
jilu1
jilu1 reviewed Nov 25, 2019
View reviewed changes
Copy link
Contributor

@jilu1 jilu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized that WAIT_TIMEOUT is now a required environment variable, it makes sense to uncomment it from .env.example. Do you agree?

@tomreece
Copy link
Contributor

@jilu1 Are you sure that WAIT_TIMEOUT is required now?
it looks to me like defaults are provided but I haven’t ran it locally to confirm.

If it is in fact required, I think we should undo that and make it NOT required. We should provide a sensible default of 30 seconds or something like that.

@jilu1
Copy link
Contributor

jilu1 commented Nov 25, 2019 •
edited
Loading

@tomreece I saw it from a different perspective that WAIT_TIMEOUT is always required now but it’s Ok with me if we want to "hide" it from .env.

@jilu1 jilu1 merged commit 4bbcab4 into develop Nov 26, 2019
@KevinBKozan KevinBKozan deleted the MQE-1520 branch December 12, 2019 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jilu1 jilu1 jilu1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KevinBKozan @coveralls @tomreece @jilu1 @soumyau